fix IKE phase1 rekeying #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As for the other diffs, please, make sure to pass |
|
Please, amend the commit message to comply to Conventional Commit and now rebase off d20eec6 👍🏻 |
|
This linting is a bit to strict for my taste: So IKE is not allowed in the subject and I must replace it with ike? To be honest, I thinking about changing all the commit subjects to "fix: minor improvements" to make it happy... |
Commit 074e1ce missed the changes to use the provied i_cookie and r_cookie. See: https://lists.unix-ag.uni-kl.de/pipermail/vpnc-devel/2015-June/004163.html Signed-off-by: Ulrich Weber <ulrich.weber@gmail.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 074e1ce missed the changes to use the provied i_cookie and r_cookie. See: https://lists.unix-ag.uni-kl.de/pipermail/vpnc-devel/2015-June/004163.html